Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue of missing wires when multiple blocks are connected to other multiple blocks through a single block (port) #339

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

BkPankaj
Copy link
Collaborator

Changes Made

  1. The main issue was in the backend processing, specifically in the synthesis.py file within the synthesis_module function, so I modified it to fix the problem.
  2. Restructured the overall process_wire function to properly store and map multiple wires. The wire_check_source and wire_check_target dictionaries now store intermediate wires by checking the wire ports (i.e., input-out, output-in).
  3. After refining the valid_wires, the wires are checked against blocks with global ports. Based on the source and target, wires are connected. If multiple wires are present, another iteration connects all new wires to the relevant port.
  4. Removed duplicate wires using a set. This process continues until all wires are mapped correctly.

Related Issues

Fixes: #338

Build zip file

Test_Ckt_Build.zip

Screenshots

Data.json with missing wires:
Screenshot from 2024-09-17 21-54-45

After resolving data.json (1):
Screenshot from 2024-09-18 11-11-19

After resolving data.json (2):
Screenshot from 2024-09-18 11-11-30

Output log:
Screenshot from 2024-09-18 11-10-39

Circuit image:
Screenshot from 2024-09-17 23-18-13

@BkPankaj BkPankaj added v3.6 bug Something isn't working python Pull requests that update Python code labels Sep 18, 2024
@BkPankaj
Copy link
Collaborator Author

Hello @toshan-luktuke @jmplaza sir,
The pull request is now ready for review and merging. I would appreciate it if you could review the changes and proceed with the merge. Please let me know if there are any additional modifications required.

@toshan-luktuke toshan-luktuke merged commit 122b26b into master Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code v3.6
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wires are missing for multiple blocks connected to multiple blocks through a single block (port)
2 participants